Priority senders #5959

fab-10 · 2023-09-27T19:04:33Z

PR description

~~This PR is build on top of #5966 so please check it first. Relative diff~~

This PR expand the concept of priority of txs and senders. Currently in Besu by default every tx sent using the RPC API is called local, and local is also a synonym for priority, that means that the tx does not need to satisfy the min price option and it is selected first when building a block, the txs received via p2p are called remote and haven't any priority.
It is possible to disable this default behavior passing the option --tx-pool-disable-locals, and all txs are treated the same.
This simple approach does not works well if Besu is used as a gateway to publish txs for multiple senders, when the node owner what to prioritize only a subset of them, to support this use case, this PR add the --tx-pool-priority-senders option, with it is possible to specify the list of senders, whom txs have priority, regardless their origin, both local or remote.

Since local is not always synonym of priority, the concepts have been separated, and so a PendingTransaction has both attributes as distinct fields, where local is now only used to identify the source and priority is used to apply or not the min price option and during the selection when building a block. To note that txs with priority will be dropped from the pool after the other ones.

To follow the new semantic of --tx-pool-disable-locals has been deprecated for removal in favor of --tx-pool-no-local-priority

To resume the possibility of mixing the priority options are:

Default (no option specified): All txs sent via RPC API are prioritized
--tx-pool-no-local-priority=true: No tx is prioritized
--tx-pool-priority-senders=sender1,sender2: All txs sent via RPC API are prioritized + all txs sent by sender1 and sender2
--tx-pool-no-local-priority=true --tx-pool-priority-senders=sender1,sender2: Only txs sent by sender1 and sender2 are prioritized

No functional or performance regressions found during the test.

Comparison with prev release (A this PR, B current stable release)

Block Value

Txs

Gas used

Fixed Issue(s)

Partially fixes #5829

Signed-off-by: Fabio Di Fabio <[email protected]>

…ayer Signed-off-by: Fabio Di Fabio <[email protected]>

Signed-off-by: Fabio Di Fabio <[email protected]>

Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]>

Signed-off-by: Fabio Di Fabio <[email protected]>

…n-filter2

Signed-off-by: Fabio Di Fabio <[email protected]>

# Conflicts: # ethereum/eth/src/test/java/org/hyperledger/besu/ethereum/eth/transactions/AbstractTransactionPoolTest.java

# Conflicts: # ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionPool.java # ethereum/eth/src/test/java/org/hyperledger/besu/ethereum/eth/transactions/AbstractTransactionPoolTest.java # ethereum/eth/src/test/java/org/hyperledger/besu/ethereum/eth/transactions/layered/LayeredPendingTransactionsTest.java

Signed-off-by: Fabio Di Fabio <[email protected]>

… creation Signed-off-by: Fabio Di Fabio <[email protected]>

Signed-off-by: Fabio Di Fabio <[email protected]>

github-actions · 2023-09-27T19:04:49Z

I thought about documentation and added the doc-change-required label to this PR if updates are required.
I thought about the changelog and included a changelog update if required.
If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Signed-off-by: Fabio Di Fabio <[email protected]>

...eum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/PendingTransaction.java

# Conflicts: # ethereum/blockcreation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/BlockTransactionSelector.java

Signed-off-by: Fabio Di Fabio <[email protected]>

# Conflicts: # datatypes/src/main/java/org/hyperledger/besu/datatypes/PendingTransaction.java # ethereum/blockcreation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/txselection/BlockTransactionSelector.java # ethereum/blockcreation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/txselection/selectors/PriceTransactionSelector.java # ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/PendingTransaction.java # ethereum/eth/src/test/java/org/hyperledger/besu/ethereum/eth/transactions/layered/LayeredPendingTransactionsTest.java # ethereum/eth/src/test/java/org/hyperledger/besu/ethereum/eth/transactions/sorter/AccountTransactionOrderTest.java

Signed-off-by: Fabio Di Fabio <[email protected]>

matthew1001 · 2023-10-10T17:05:19Z

@fab-10 Do you know which release the deprecated --tx-pool-disable-locals option will likely be removed in? I suspect some permissioned-chain users will be using that option.

fab-10 · 2023-10-10T17:22:51Z

@matthew1001 removal date is not yet set, but the feature is not removed, only the option is renamed to -tx-pool-no-local-priority` to better reflect that we are talking about priority tx does not always match with local tx

# Conflicts: # ethereum/blockcreation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/txselection/BlockTransactionSelector.java # ethereum/eth/src/test/java/org/hyperledger/besu/ethereum/eth/transactions/AbstractTransactionPoolTest.java

Signed-off-by: Fabio Di Fabio <[email protected]>

besu/src/main/java/org/hyperledger/besu/cli/options/stable/TransactionPoolOptions.java

datatypes/src/main/java/org/hyperledger/besu/datatypes/PendingTransaction.java

ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionPool.java

...src/main/java/org/hyperledger/besu/ethereum/eth/transactions/layered/SparseTransactions.java

Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]>

…ty-senders

Signed-off-by: Fabio Di Fabio <[email protected]>

CHANGELOG.md

Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]>

Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>

Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]>

* Expose getSize to transaction interface (#5983) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add parameters to EVM library fluent API (#5930) Add the ability to configure more parameters in the fluent API. Specifically contract address, coinbase, difficulty, mixHash/prevRandao, baseFee, block number, timestamp, gas limit, previous block hashes, and versioned hashes. Also create EVM forks parametrically instead of by a method name. Signed-off-by: Danno Ferrin <[email protected]> * Validation ordering (#5986) * re-ordering error reporting priority * fixes fork checking on getPayload * adds acceptance test reproducing an issue where built blocks have proofs > txs * test coverage and fix for subtle re-org bug prior to proposals --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [4844] EngineNewPayload - Add Blob Count validation (#5973) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Plugin Api - Add evaluateTransactionPostProcessing to TransactionSelector interface (#5988) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Only use the builder to create transactions (#5980) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Bump version to 23.10.1-SNAPSHOT (#5990) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * hive tests explicitly attempt zero (#5993) Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add plugins summary (#5964) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Tests for GraphQL Cancun fields (#5975) * Tests for GraphQL Cancun fields Add tests for GraphQL fields added to support cancun. Also, re-work test case inclusion code and update tests impacted by adding a new block to the chain. Signed-off-by: Danno Ferrin <[email protected]> * unneeded deltas in genesis file Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - Simplify plugin transaction selector interface to return object instead of list (#5995) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Change Array Copying (#5998) * Change Array Copying Change array copying by re-using arrays when safe. Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> * different bigint API Signed-off-by: Danno Ferrin <[email protected]> * straddle case Signed-off-by: Danno Ferrin <[email protected]> * less stack traces Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Notify plugins when transaction is selected/rejected (#6005) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Base EIP-6110 on top of Cancun (#5752) This is to base the existed implementation of EIP-6110 from Shanghai to Cancun. As well, it updates the implementation according to the latest Engine API specification. Changes include: - Remove 6110 related changes from engine_newPayloadV2 and engine_getPayloadV2 - Rename deposits to depositReceipts in EnginePayloadParameter - Introduce engine_newPayloadV6110 and engine_getPayloadV6110 that are based on engine_newPayloadV3 and engine_getPayloadV3 - Revamp the existed 6110 acceptance test --- Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add method to disable root verification for T8n and not Reference tests (#6013) * add method to disable root verification for T8n and not Reference tests Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction detachedCopy to optimize txpool memory usage (#5985) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Use existing Bytes48 for KZGCommitment and KZGProof (#5997) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Send TransactionSelectionResult to the plugin when not transaction is not selected (#6010) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update 23.10.0 changelog (#6017) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction Validation and Selection Plugin API update (#6020) change Transaction Validation and Selection Plugin to make them more useful Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Co-authored-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Force the use of jdk18 version of Bouncy Castle library (#5748) This avoid that any dependency can include the jdk15 version in the distribution. Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * remove code duplication (#6028) Signed-off-by: Stefan <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * docs: fix typo (#6029) Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: vuittont60 <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Standardize pubkey and public key naming in deposit (#6012) --------- Signed-off-by: naviechan <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Optimize Eth_feeHistory RPC method (#6011) * Add a cache to EthFeeHistory and improve rewards algorithm * cache the rewards by hash instead of block number * Add final on some fields Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Cache last blocks data (block headers, block bodies, transactions' receipts and total difficulty) (#6009) * Add a flag --cache-last-blocks to cache last n blocks, The default value is 0 Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Sort only once rewardPercentiles instead of doing it for each block header (#6035) Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * link to issue 5772 (#6038) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * fix incorrect argument passing in blockParameter of TraceCallMany class (#6034) Signed-off-by: seongmin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix 23.10.0 Breaking Changes changelog entry (#6040) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Priority senders (#5959) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fcu v2 defer fork validation (#6037) * more error handling --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix typos (#6036) Signed-off-by: shuoer86 <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add X (Twitter) to README, Fix Roadmap Hyperlink (#6047) * Add X to README, Fix Roadmap Hyperlink Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> --------- Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Unsigned timestamps and blob gas used (#6046) * lots of places an unsigned timestamp is a problem * adds unchecked annotations to OptionalUnsignedLong rpc parameter type --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [MINOR] ux improvements (#6049) * log command line option that is affected * made plugins summary log part of config overview * check for null plugin context Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog release (#6062) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Dencun corner cases (#6060) * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-22b78733e37a697fa8d1d8a02d2a87fe5ccea9cf67c34ce5e6311f024c14abd6L643-R738 Signed-off-by: Sally MacFarlane <[email protected]> * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-61db834b59eae5ce5c438462505de1add8fa244deda830742060d15f668a9806R39-R44 Signed-off-by: Sally MacFarlane <[email protected]> * formatting Signed-off-by: Sally MacFarlane <[email protected]> * update the EIP-6110 acceptance tests Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog and gradle properties to next release Signed-off-by: Gabriel-Trintinalia <[email protected]> --------- Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: seongmin <[email protected]> Signed-off-by: shuoer86 <[email protected]> Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: NC <[email protected]> Co-authored-by: matkt <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: vuittont60 <[email protected]> Co-authored-by: ahamlat <[email protected]> Co-authored-by: seongmin <[email protected]> Co-authored-by: shuoer86 <[email protected]> Co-authored-by: David Cardenas <[email protected]>

* Expose getSize to transaction interface (hyperledger#5983) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add parameters to EVM library fluent API (hyperledger#5930) Add the ability to configure more parameters in the fluent API. Specifically contract address, coinbase, difficulty, mixHash/prevRandao, baseFee, block number, timestamp, gas limit, previous block hashes, and versioned hashes. Also create EVM forks parametrically instead of by a method name. Signed-off-by: Danno Ferrin <[email protected]> * Validation ordering (hyperledger#5986) * re-ordering error reporting priority * fixes fork checking on getPayload * adds acceptance test reproducing an issue where built blocks have proofs > txs * test coverage and fix for subtle re-org bug prior to proposals --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [4844] EngineNewPayload - Add Blob Count validation (hyperledger#5973) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Plugin Api - Add evaluateTransactionPostProcessing to TransactionSelector interface (hyperledger#5988) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Only use the builder to create transactions (hyperledger#5980) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Bump version to 23.10.1-SNAPSHOT (hyperledger#5990) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * hive tests explicitly attempt zero (hyperledger#5993) Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add plugins summary (hyperledger#5964) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Tests for GraphQL Cancun fields (hyperledger#5975) * Tests for GraphQL Cancun fields Add tests for GraphQL fields added to support cancun. Also, re-work test case inclusion code and update tests impacted by adding a new block to the chain. Signed-off-by: Danno Ferrin <[email protected]> * unneeded deltas in genesis file Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - Simplify plugin transaction selector interface to return object instead of list (hyperledger#5995) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Change Array Copying (hyperledger#5998) * Change Array Copying Change array copying by re-using arrays when safe. Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> * different bigint API Signed-off-by: Danno Ferrin <[email protected]> * straddle case Signed-off-by: Danno Ferrin <[email protected]> * less stack traces Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Notify plugins when transaction is selected/rejected (hyperledger#6005) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Base EIP-6110 on top of Cancun (hyperledger#5752) This is to base the existed implementation of EIP-6110 from Shanghai to Cancun. As well, it updates the implementation according to the latest Engine API specification. Changes include: - Remove 6110 related changes from engine_newPayloadV2 and engine_getPayloadV2 - Rename deposits to depositReceipts in EnginePayloadParameter - Introduce engine_newPayloadV6110 and engine_getPayloadV6110 that are based on engine_newPayloadV3 and engine_getPayloadV3 - Revamp the existed 6110 acceptance test --- Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add method to disable root verification for T8n and not Reference tests (hyperledger#6013) * add method to disable root verification for T8n and not Reference tests Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction detachedCopy to optimize txpool memory usage (hyperledger#5985) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Use existing Bytes48 for KZGCommitment and KZGProof (hyperledger#5997) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Send TransactionSelectionResult to the plugin when not transaction is not selected (hyperledger#6010) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update 23.10.0 changelog (hyperledger#6017) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction Validation and Selection Plugin API update (hyperledger#6020) change Transaction Validation and Selection Plugin to make them more useful Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Co-authored-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Force the use of jdk18 version of Bouncy Castle library (hyperledger#5748) This avoid that any dependency can include the jdk15 version in the distribution. Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * remove code duplication (hyperledger#6028) Signed-off-by: Stefan <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * docs: fix typo (hyperledger#6029) Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: vuittont60 <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Standardize pubkey and public key naming in deposit (hyperledger#6012) --------- Signed-off-by: naviechan <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Optimize Eth_feeHistory RPC method (hyperledger#6011) * Add a cache to EthFeeHistory and improve rewards algorithm * cache the rewards by hash instead of block number * Add final on some fields Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Cache last blocks data (block headers, block bodies, transactions' receipts and total difficulty) (hyperledger#6009) * Add a flag --cache-last-blocks to cache last n blocks, The default value is 0 Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Sort only once rewardPercentiles instead of doing it for each block header (hyperledger#6035) Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * link to issue 5772 (hyperledger#6038) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * fix incorrect argument passing in blockParameter of TraceCallMany class (hyperledger#6034) Signed-off-by: seongmin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix 23.10.0 Breaking Changes changelog entry (hyperledger#6040) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Priority senders (hyperledger#5959) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fcu v2 defer fork validation (hyperledger#6037) * more error handling --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix typos (hyperledger#6036) Signed-off-by: shuoer86 <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add X (Twitter) to README, Fix Roadmap Hyperlink (hyperledger#6047) * Add X to README, Fix Roadmap Hyperlink Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> --------- Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Unsigned timestamps and blob gas used (hyperledger#6046) * lots of places an unsigned timestamp is a problem * adds unchecked annotations to OptionalUnsignedLong rpc parameter type --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [MINOR] ux improvements (hyperledger#6049) * log command line option that is affected * made plugins summary log part of config overview * check for null plugin context Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog release (hyperledger#6062) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Dencun corner cases (hyperledger#6060) * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-22b78733e37a697fa8d1d8a02d2a87fe5ccea9cf67c34ce5e6311f024c14abd6L643-R738 Signed-off-by: Sally MacFarlane <[email protected]> * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-61db834b59eae5ce5c438462505de1add8fa244deda830742060d15f668a9806R39-R44 Signed-off-by: Sally MacFarlane <[email protected]> * formatting Signed-off-by: Sally MacFarlane <[email protected]> * update the EIP-6110 acceptance tests Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog and gradle properties to next release Signed-off-by: Gabriel-Trintinalia <[email protected]> --------- Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: seongmin <[email protected]> Signed-off-by: shuoer86 <[email protected]> Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: NC <[email protected]> Co-authored-by: matkt <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: vuittont60 <[email protected]> Co-authored-by: ahamlat <[email protected]> Co-authored-by: seongmin <[email protected]> Co-authored-by: shuoer86 <[email protected]> Co-authored-by: David Cardenas <[email protected]> Signed-off-by: Justin Florentine <[email protected]>

Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>

fab-10 and others added 16 commits September 25, 2023 14:29

Improve performance when promoting transaction from next layers

17220d8

Signed-off-by: Fabio Di Fabio <[email protected]>

Always enforce promotion filter for transactions in the prioritized l…

80a0845

…ayer Signed-off-by: Fabio Di Fabio <[email protected]>

Fix typo

919734e

Signed-off-by: Fabio Di Fabio <[email protected]>

Apply suggestions from code review

0b4bfa9

Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]>

implement code review suggestions

b4e74e9

Signed-off-by: Fabio Di Fabio <[email protected]>

Merge branch 'main' into txpool-promotion-performance

0b72427

Add priority senders option

b393618

Signed-off-by: Fabio Di Fabio <[email protected]>

Merge branch 'main' into txpool-promotion-performance

c3e1fd8

Merge branch 'txpool-promotion-performance' into prioritized-promotio…

fa50005

…n-filter2

Merge branch 'prioritized-promotion-filter2' into priority-senders

4d5e015

Transaction pool unit tests refactoring to remove duplications

f4e04a2

Signed-off-by: Fabio Di Fabio <[email protected]>

Merge branch 'txpool-test-refactor' into priority-senders

8b45df7

# Conflicts: # ethereum/eth/src/test/java/org/hyperledger/besu/ethereum/eth/transactions/AbstractTransactionPoolTest.java

Use a Set for priority senders and remove commented code

e6d2761

Signed-off-by: Fabio Di Fabio <[email protected]>

use hasPriority instead of isLocalSender when selecting txs for block…

185dcc6

… creation Signed-off-by: Fabio Di Fabio <[email protected]>

Rename disable-locals to no-local-priority and unit tests

b36a09d

Signed-off-by: Fabio Di Fabio <[email protected]>

Sort transactions by priority

3506f63

Signed-off-by: Fabio Di Fabio <[email protected]>

fab-10 force-pushed the priority-senders branch from 67cf062 to 3506f63 Compare September 27, 2023 19:31

github-advanced-security bot found potential problems Sep 28, 2023

View reviewed changes

...eum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/PendingTransaction.java Dismissed Show dismissed Hide dismissed

Merge branch 'main' into priority-senders

712b2c0

# Conflicts: # ethereum/blockcreation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/BlockTransactionSelector.java

fab-10 force-pushed the priority-senders branch from 97dbf0e to 712b2c0 Compare September 28, 2023 09:28

fab-10 added 2 commits September 28, 2023 12:58

[skip-ci] Add tests

542ef6f

Signed-off-by: Fabio Di Fabio <[email protected]>

Discard priority sender at last and more tests

33c0ded

Signed-off-by: Fabio Di Fabio <[email protected]>

fab-10 added the doc-change-required Indicates an issue or PR that requires doc to be updated label Sep 28, 2023

fab-10 added 2 commits September 28, 2023 19:34

Merge branch 'main' into priority-senders

bbaa4d8

Update CHANGELOG

ff1944c

Signed-off-by: Fabio Di Fabio <[email protected]>

fab-10 marked this pull request as ready for review September 28, 2023 17:52

fab-10 mentioned this pull request Sep 29, 2023

Layered TxPool Never evicts local transactions and they should be given priority. #5829

Closed

fab-10 added 2 commits October 2, 2023 15:16

Update ReplayTest and txpool metrics for priority senders

66a5f03

Signed-off-by: Fabio Di Fabio <[email protected]>

Merge branch 'main' into priority-senders

f7d98a4

fab-10 force-pushed the priority-senders branch from 4c90bbe to f7d98a4 Compare October 5, 2023 10:11

alexandratran mentioned this pull request Oct 6, 2023

Document priority senders options hyperledger/besu-docs#1416

Closed

alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Oct 6, 2023

fab-10 added 3 commits October 12, 2023 14:07

Update CHANGELOG

f1b7111

Signed-off-by: Fabio Di Fabio <[email protected]>

Add detachedCopy to priority pending transaction

2d0e09c

Signed-off-by: Fabio Di Fabio <[email protected]>

macfarla reviewed Oct 16, 2023

View reviewed changes

fab-10 and others added 6 commits October 16, 2023 11:13

Apply suggestions from code review

a44a7bb

Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]>

Merge branch 'main' into priority-senders

09f3738

Merge branch 'priority-senders' of github.com:fab-10/besu into priori…

e4f5ac4

…ty-senders

Fix tests

0faf055

Signed-off-by: Fabio Di Fabio <[email protected]>

Merge branch 'main' into priority-senders

a1466b8

Spotless

1b785d0

Signed-off-by: Fabio Di Fabio <[email protected]>

macfarla approved these changes Oct 17, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

fab-10 and others added 2 commits October 17, 2023 12:41

[skip-ci] Update CHANGELOG.md

2257731

Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]>

Merge branch 'main' into priority-senders

f4254e5

fab-10 enabled auto-merge (squash) October 17, 2023 10:47

fab-10 merged commit 6d100f3 into hyperledger:main Oct 17, 2023
19 checks passed

fab-10 deleted the priority-senders branch October 17, 2023 12:19

Gabriel-Trintinalia pushed a commit to Gabriel-Trintinalia/besu that referenced this pull request Oct 20, 2023

Priority senders (hyperledger#5959)

bf48b34

Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>

NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023

Priority senders (hyperledger#5959)

4485b03

Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Priority senders #5959

Priority senders #5959

fab-10 commented Sep 27, 2023 •

edited

Loading

github-actions bot commented Sep 27, 2023 •

edited by fab-10

Loading

matthew1001 commented Oct 10, 2023

fab-10 commented Oct 10, 2023

Priority senders #5959

Priority senders #5959

Conversation

fab-10 commented Sep 27, 2023 • edited Loading

PR description

Fixed Issue(s)

github-actions bot commented Sep 27, 2023 • edited by fab-10 Loading

matthew1001 commented Oct 10, 2023

fab-10 commented Oct 10, 2023

fab-10 commented Sep 27, 2023 •

edited

Loading

github-actions bot commented Sep 27, 2023 •

edited by fab-10

Loading